Change recovery_init_sync_method to PGC_SIGHUP.

The setting has no effect except during startup.  It's still nice to be
able to change it dynamically, which is expected to be pretty useful to
an admin following crash recovery when restarting the cluster is not so
appealing.

Per discussions following commits 2941138e6 and 61752afb2.

Author: Justin Pryzby 
Reviewed-by: Fujii Masao 
Reviewed-by: Michael Paquier 
Reviewed-by: Thomas Munro 
Discussion: https://postgr.es/m/20210529192321.GM2082%40telsasoft.com

diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 03b33cfb7e453aa39e0d1d973e1203e7ed368688..3eee9883595ff2eca518893d375f526f6e46657f 100644 (file)
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -9929,7 +9929,8 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir'
         appear only in kernel logs.
        
        
-        This parameter can only be set at server start.
+        This parameter can only be set in the
+        postgresql.conf file or on the server command line.
        
       
      

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index eaeeee58a0bd83a9127e2b1c3eeee3c220b3473e..297e705b806a6c0ad069bd1fda7d03b55810d0eb 100644 (file)
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -4946,7 +4946,7 @@ static struct config_enum ConfigureNamesEnum[] =
    },
 
    {
-       {"recovery_init_sync_method", PGC_POSTMASTER, ERROR_HANDLING_OPTIONS,
+       {"recovery_init_sync_method", PGC_SIGHUP, ERROR_HANDLING_OPTIONS,
            gettext_noop("Sets the method for synchronizing the data directory before crash recovery."),
        },
        &recovery_init_sync_method,

diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index a5a7174b0e751d17876292135597b1891b87d60a..af04ec3c744e76dbdc7eb585e0ea3684cc46183c 100644 (file)
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -772,7 +772,6 @@
                    # data?
                    # (change requires restart)
 #recovery_init_sync_method = fsync # fsync, syncfs (Linux 5.8+)
-                   # (change requires restart)
 
 
 #------------------------------------------------------------------------------