Remove obsolete IndexBulkDeleteResult stats field.
authorPeter Geoghegan
Fri, 12 Feb 2021 00:49:41 +0000 (16:49 -0800)
committerPeter Geoghegan
Fri, 12 Feb 2021 00:49:41 +0000 (16:49 -0800)
The pages_removed field is no longer used for anything.  It hasn't been
possible for an index to physically shrink since old-style VACUUM FULL
was removed by commit 0a469c87.

src/backend/access/gist/gistvacuum.c
src/include/access/genam.h

index 94a7e12763931559987396c9e0b35ccd240fa1d2..ddecb8ab18ef435b63f56dfd63c3f0d700853e8d 100644 (file)
@@ -546,9 +546,6 @@ gistvacuum_delete_empty_pages(IndexVacuumInfo *info, GistVacState *vstate)
 
        ReleaseBuffer(buffer);
 
-       /* update stats */
-       vstate->stats->pages_removed += deleted;
-
        /*
         * We can stop the scan as soon as we have seen the downlinks, even if
         * we were not able to remove them all.
index 0eab1508d37538eb940a0926de6f2a7a54bef874..ffa1a4c80dbe190ca452fd9241af67920479c746 100644 (file)
@@ -63,16 +63,14 @@ typedef struct IndexVacuumInfo
  * of which this is just the first field; this provides a way for ambulkdelete
  * to communicate additional private data to amvacuumcleanup.
  *
- * Note: pages_removed is the amount by which the index physically shrank,
- * if any (ie the change in its total size on disk).  pages_deleted and
- * pages_free refer to free space within the index file.  Some index AMs
- * may compute num_index_tuples by reference to num_heap_tuples, in which
- * case they should copy the estimated_count field from IndexVacuumInfo.
+ * Note: pages_deleted and pages_free refer to free space within the index
+ * file.  Some index AMs may compute num_index_tuples by reference to
+ * num_heap_tuples, in which case they should copy the estimated_count field
+ * from IndexVacuumInfo.
  */
 typedef struct IndexBulkDeleteResult
 {
    BlockNumber num_pages;      /* pages remaining in index */
-   BlockNumber pages_removed;  /* # removed during vacuum operation */
    bool        estimated_count;    /* num_index_tuples is an estimate */
    double      num_index_tuples;   /* tuples remaining */
    double      tuples_removed; /* # removed during vacuum operation */