Suppress variable-set-but-not-used warnings from clang 15.

clang 15+ will issue a set-but-not-used warning when the only
use of a variable is in autoincrements (e.g., "foo++;").
That's perfectly sensible, but it detects a few more cases that
we'd not noticed before.  Silence the warnings with our usual
methods, such as PG_USED_FOR_ASSERTS_ONLY, or in one case by
actually removing a useless variable.

One thing that we can't nicely get rid of is that with %pure-parser,
Bison emits "yynerrs" as a local variable that falls foul of this
warning.  To silence those, I inserted "(void) yynerrs;" in the
top-level productions of affected grammars.

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
annoying compiler warnings but changes no behavior.  Hence,
back-patch to 9.5, which is as far as these patches go without
issues.  (A preliminary check shows that the prior branches
need some other set-but-not-used cleanups too, so I'll leave
them for another day.)

Discussion: https://postgr.es/m/514615.1663615243@sss.pgh.pa.us

diff --git a/src/backend/access/gist/gistxlog.c b/src/backend/access/gist/gistxlog.c
index 6464cb9281b90607a66e23ec5fee41f8befed3c8..76723fa805e02b5d3db1adba4270fcf8cac645a1 100644 (file)
--- a/src/backend/access/gist/gistxlog.c
+++ b/src/backend/access/gist/gistxlog.c
@@ -81,7 +81,7 @@ gistRedoPageUpdateRecord(XLogReaderState *record)
        char       *begin;
        char       *data;
        Size        datalen;
-       int         ninserted = 0;
+       int         ninserted PG_USED_FOR_ASSERTS_ONLY = 0;
 
        data = begin = XLogRecGetBlockData(record, 0, &datalen);
 

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 757760eadaedb80923b2fc80b6f8f472d8cfea27..134a6481b99398f96e9f03cfc6d91760ea285f35 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -2151,7 +2151,7 @@ AdvanceXLInsertBuffer(XLogRecPtr upto, bool opportunistic)
    XLogRecPtr  NewPageEndPtr = InvalidXLogRecPtr;
    XLogRecPtr  NewPageBeginPtr;
    XLogPageHeader NewPage;
-   int         npages = 0;
+   int         npages pg_attribute_unused() = 0;
 
    LWLockAcquire(WALBufMappingLock, LW_EXCLUSIVE);
 

diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index fe2af568c9133a8bf3c734cbe142d327e8ad6624..25fe6c03cde22ff76ae31d527f5c8fb1fdfdcc28 100644 (file)
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -827,6 +827,7 @@ parse_toplevel:
            stmtmulti
            {
                pg_yyget_extra(yyscanner)->parsetree = $1;
+               (void) yynerrs;     /* suppress compiler warning */
            }
            | MODE_TYPE_NAME Typename
            {

diff --git a/src/backend/utils/adt/array_typanalyze.c b/src/backend/utils/adt/array_typanalyze.c
index e873d228592a6ffd44737b21cd4f18a9329e4091..8993d23e18b6e9912475e2719b4ef3e8e978dda0 100644 (file)
--- a/src/backend/utils/adt/array_typanalyze.c
+++ b/src/backend/utils/adt/array_typanalyze.c
@@ -218,7 +218,6 @@ compute_array_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,
 {
    ArrayAnalyzeExtraData *extra_data;
    int         num_mcelem;
-   int         null_cnt = 0;
    int         null_elem_cnt = 0;
    int         analyzed_rows = 0;
 
@@ -320,8 +319,7 @@ compute_array_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,
        value = fetchfunc(stats, array_no, &isnull);
        if (isnull)
        {
-           /* array is null, just count that */
-           null_cnt++;
+           /* ignore arrays that are null overall */
            continue;
        }
 

diff --git a/src/backend/utils/adt/jsonpath_gram.y b/src/backend/utils/adt/jsonpath_gram.y
index b5cf865f3c1c8861dc93b5c7191440d3211162e2..3377cc81cbf45f6b964f47b509be4e042563cad9 100644 (file)
--- a/src/backend/utils/adt/jsonpath_gram.y
+++ b/src/backend/utils/adt/jsonpath_gram.y
@@ -130,6 +130,7 @@ result:
                                        *result = palloc(sizeof(JsonPathParseResult));
                                        (*result)->expr = $2;
                                        (*result)->lax = $1;
+                                       (void) yynerrs;
                                    }
    | /* EMPTY */                   { *result = NULL; }
    ;

diff --git a/src/bin/pgbench/exprparse.y b/src/bin/pgbench/exprparse.y
index 56f75ccd253e74bc2e40064f12a87e933a267633..b3dd0488b2a153fad14eaf88daf55f2cc59357b0 100644 (file)
--- a/src/bin/pgbench/exprparse.y
+++ b/src/bin/pgbench/exprparse.y
@@ -80,7 +80,10 @@ static PgBenchExpr *make_case(yyscan_t yyscanner, PgBenchExprList *when_then_lis
 
 %%
 
-result: expr               { expr_parse_result = $1; }
+result: expr               {
+                               expr_parse_result = $1;
+                               (void) yynerrs; /* suppress compiler warning */
+                           }
 
 elist:                     { $$ = NULL; }
    | expr                  { $$ = make_elist($1, NULL); }