Mark assorted variables PGDLLIMPORT.

This makes life easier for extension authors who wish to support
Windows.

Brian Cloutier, slightly amended by me.

Discussion: http://postgr.es/m/CAJCy68fscdNhmzFPS4kyO00CADkvXvEa-28H-OtENk-pa2OTWw@mail.gmail.com

diff --git a/src/include/access/twophase.h b/src/include/access/twophase.h
index 71ddff7e1943d87e19cf31e19de8545502a978d9..722df26726eba60398babd5f930878f96a133a4b 100644 (file)
--- a/src/include/access/twophase.h
+++ b/src/include/access/twophase.h
@@ -25,7 +25,7 @@
 typedef struct GlobalTransactionData *GlobalTransaction;
 
 /* GUC variable */
-extern int max_prepared_xacts;
+extern PGDLLIMPORT int max_prepared_xacts;
 
 extern Size TwoPhaseShmemSize(void);
 extern void TwoPhaseShmemInit(void);

diff --git a/src/include/commands/extension.h b/src/include/commands/extension.h
index 0423350c9aa56a69d1bf21ce7da1d90344ab2a85..3d27056b954ae0eb2f25e119b3742fc81d843e96 100644 (file)
--- a/src/include/commands/extension.h
+++ b/src/include/commands/extension.h
@@ -25,7 +25,7 @@
  * installation script.
  */
 extern PGDLLIMPORT bool creating_extension;
-extern Oid CurrentExtensionObject;
+extern PGDLLIMPORT Oid CurrentExtensionObject;
 
 
 extern ObjectAddress CreateExtension(CreateExtensionStmt *stmt);

diff --git a/src/include/miscadmin.h b/src/include/miscadmin.h
index 6eda00f1368546d6d4bf80ee137835296418d3a2..df125e9c439df5bfaad12a5a7d56291c21e562f9 100644 (file)
--- a/src/include/miscadmin.h
+++ b/src/include/miscadmin.h
@@ -151,14 +151,14 @@ extern PGDLLIMPORT bool IsUnderPostmaster;
 extern bool IsBackgroundWorker;
 extern PGDLLIMPORT bool IsBinaryUpgrade;
 
-extern bool ExitOnAnyError;
+extern PGDLLIMPORT bool ExitOnAnyError;
 
 extern PGDLLIMPORT char *DataDir;
 
 extern PGDLLIMPORT int NBuffers;
-extern int MaxBackends;
-extern int MaxConnections;
-extern int max_worker_processes;
+extern PGDLLIMPORT int MaxBackends;
+extern PGDLLIMPORT int MaxConnections;
+extern PGDLLIMPORT int max_worker_processes;
 
 extern PGDLLIMPORT int MyProcPid;
 extern PGDLLIMPORT pg_time_t MyStartTime;
@@ -238,7 +238,7 @@ extern PGDLLIMPORT int IntervalStyle;
 #define MAXTZLEN       10      /* max TZ name len, not counting tr. null */
 
 extern bool enableFsync;
-extern bool allowSystemTableMods;
+extern PGDLLIMPORT bool allowSystemTableMods;
 extern PGDLLIMPORT int work_mem;
 extern PGDLLIMPORT int maintenance_work_mem;
 

diff --git a/src/include/pgtime.h b/src/include/pgtime.h
index f594d7f1ce08d3819e070512c1b874bdb374d3cd..04b1104f66f61f991bae9f8893542b2b4f5e05e1 100644 (file)
--- a/src/include/pgtime.h
+++ b/src/include/pgtime.h
@@ -70,7 +70,7 @@ extern size_t pg_strftime(char *s, size_t max, const char *format,
 
 /* these functions and variables are in pgtz.c */
 
-extern pg_tz *session_timezone;
+extern PGDLLIMPORT pg_tz *session_timezone;
 extern pg_tz *log_timezone;
 
 extern void pg_timezone_initialize(void);

diff --git a/src/include/postmaster/postmaster.h b/src/include/postmaster/postmaster.h
index d16030482fad56361eeec66f488af269e7aec976..e6f4c6153b0721893d942e96d216fa770265892b 100644 (file)
--- a/src/include/postmaster/postmaster.h
+++ b/src/include/postmaster/postmaster.h
@@ -16,7 +16,7 @@
 /* GUC options */
 extern bool EnableSSL;
 extern int ReservedBackends;
-extern int PostPortNumber;
+extern PGDLLIMPORT int PostPortNumber;
 extern int Unix_socket_permissions;
 extern char *Unix_socket_group;
 extern char *Unix_socket_directories;
@@ -44,7 +44,7 @@ extern int    postmaster_alive_fds[2];
 #define POSTMASTER_FD_OWN      1       /* kept open by postmaster only */
 #endif
 
-extern const char *progname;
+extern PGDLLIMPORT const char *progname;
 
 extern void PostmasterMain(int argc, char *argv[]) pg_attribute_noreturn();
 extern void ClosePostmasterPorts(bool am_syslogger);

diff --git a/src/include/storage/fd.h b/src/include/storage/fd.h
index a56fc5bd2256ebb3583272a52f13fddd3b89e824..c68d9064e782e84e4648815ccdf293c6aad07fb4 100644 (file)
--- a/src/include/storage/fd.h
+++ b/src/include/storage/fd.h
@@ -52,7 +52,7 @@ typedef int File;
 
 
 /* GUC parameter */
-extern int max_files_per_process;
+extern PGDLLIMPORT int max_files_per_process;
 
 /*
  * This is private to fd.c, but exported for save/restore_backend_variables()

diff --git a/src/include/storage/proc.h b/src/include/storage/proc.h
index e807a2e020da4bc1f6fcf6898b480edf403578d8..8b7dc728387345f24e0b525775f20289492838b0 100644 (file)
--- a/src/include/storage/proc.h
+++ b/src/include/storage/proc.h
@@ -208,7 +208,7 @@ typedef struct PROC_HDR
    int         startupBufferPinWaitBufId;
 } PROC_HDR;
 
-extern PROC_HDR *ProcGlobal;
+extern PGDLLIMPORT PROC_HDR *ProcGlobal;
 
 extern PGPROC *PreparedXactProcs;
 
@@ -224,7 +224,7 @@ extern PGPROC *PreparedXactProcs;
 
 
 /* configurable options */
-extern int DeadlockTimeout;
+extern PGDLLIMPORT int DeadlockTimeout;
 extern int StatementTimeout;
 extern int LockTimeout;
 extern bool log_lock_waits;

diff --git a/src/include/tcop/dest.h b/src/include/tcop/dest.h
index 5bcca3fbcaacdf9cba7784c977dac2fefe3d6790..8108973c93486f5bb6ea69473b1aecaefdfbaab3 100644 (file)
--- a/src/include/tcop/dest.h
+++ b/src/include/tcop/dest.h
@@ -125,7 +125,8 @@ struct _DestReceiver
    /* Private fields might appear beyond this point... */
 };
 
-extern DestReceiver *None_Receiver;        /* permanent receiver for DestNone */
+extern PGDLLIMPORT DestReceiver *None_Receiver; /* permanent receiver for
+                                                * DestNone */
 
 /* The primary destination management functions */
 

diff --git a/src/include/tcop/tcopprot.h b/src/include/tcop/tcopprot.h
index 96c5b8b3d44bbd080f7f97c10fb11db04876812d..19dc8ec256e1387eea96268914ac61c283b20ea5 100644 (file)
--- a/src/include/tcop/tcopprot.h
+++ b/src/include/tcop/tcopprot.h
@@ -44,7 +44,7 @@ typedef enum
    LOGSTMT_ALL                 /* log all statements */
 } LogStmtLevel;
 
-extern int log_statement;
+extern PGDLLIMPORT int log_statement;
 
 extern List *pg_parse_query(const char *query_string);
 extern List *pg_analyze_and_rewrite(Node *parsetree, const char *query_string,

diff --git a/src/include/utils/guc.h b/src/include/utils/guc.h
index 03a5dd1c573127b44c0faeb0783a2bf6832b259b..368375925a4da32aa1bd4ff6504a54430b7f4345 100644 (file)
--- a/src/include/utils/guc.h
+++ b/src/include/utils/guc.h
@@ -247,8 +247,8 @@ extern bool default_with_oids;
 extern bool SQL_inheritance;
 
 extern int log_min_error_statement;
-extern int log_min_messages;
-extern int client_min_messages;
+extern PGDLLIMPORT int log_min_messages;
+extern PGDLLIMPORT int client_min_messages;
 extern int log_min_duration_statement;
 extern int log_temp_files;
 
@@ -257,7 +257,7 @@ extern int  temp_file_limit;
 extern int num_temp_buffers;
 
 extern char *cluster_name;
-extern char *ConfigFileName;
+extern PGDLLIMPORT char *ConfigFileName;
 extern char *HbaFileName;
 extern char *IdentFileName;
 extern char *external_pid_file;

diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h
index 7f21ea77d01db5789907bab3ce2cd2e170248a52..35de8aba61c4e9d1fbec5a61d3ad39e98e193515 100644 (file)
--- a/src/include/utils/snapmgr.h
+++ b/src/include/utils/snapmgr.h
@@ -20,10 +20,10 @@
 
 extern bool FirstSnapshotSet;
 
-extern TransactionId TransactionXmin;
-extern TransactionId RecentXmin;
-extern TransactionId RecentGlobalXmin;
-extern TransactionId RecentGlobalDataXmin;
+extern PGDLLIMPORT TransactionId TransactionXmin;
+extern PGDLLIMPORT TransactionId RecentXmin;
+extern PGDLLIMPORT TransactionId RecentGlobalXmin;
+extern PGDLLIMPORT TransactionId RecentGlobalDataXmin;
 
 extern Snapshot GetTransactionSnapshot(void);
 extern Snapshot GetLatestSnapshot(void);