If RelationBuildDesc() fails to open a critical system index, PANIC with

a relevant error message instead of just dumping core.  Odd that nobody
reported this before Darren Reed.

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 71abf31f099aef345f760e6bd07b00f06cb52fd2..ca4305c60ba8dd27100e8674b37e2592b47a4636 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *   $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.266 2008/01/01 19:45:53 momjian Exp $
+ *   $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.267 2008/02/27 17:44:19 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2550,7 +2550,10 @@ RelationCacheInitializePhase2(void)
 
 #define LOAD_CRIT_INDEX(indexoid) \
        do { \
-           ird = RelationBuildDesc((indexoid), NULL); \
+           ird = RelationBuildDesc(indexoid, NULL); \
+           if (ird == NULL) \
+               elog(PANIC, "could not open critical system index %u", \
+                    indexoid); \
            ird->rd_isnailed = true; \
            ird->rd_refcnt = 1; \
        } while (0)