This simple patch fixes broken Makefile, broken ApplySnapshot and

makes all utilities honour --verbose command line option.

--
Yours, Alexey V. Borzov, Webmaster of RDW.ru

diff --git a/contrib/rserv/ApplySnapshot.in b/contrib/rserv/ApplySnapshot.in
index a3b79e19eeadbf8b9731066e9cc6d621435fad72..695605f139b35b6404ab003cc0d1eea12da3128e 100644 (file)
--- a/contrib/rserv/ApplySnapshot.in
+++ b/contrib/rserv/ApplySnapshot.in
@@ -32,11 +32,13 @@ $sinfo = "$sinfo host=$opt_host" if (defined($opt_host));
 $sinfo = "$sinfo user=$opt_user" if (defined($opt_user));
 $sinfo = "$sinfo password=$opt_password" if (defined($opt_password));
 
-my $conn = Pg::connectdb(sinfo);
+my $conn = Pg::connectdb($sinfo);
 
 my $inpf = new IO::File;
 $inpf = STDIN;
 
+$RServ::quiet = !$verbose;
+
 $res = ApplySnapshot ($conn, $inpf);
 
 if ($res > 0)

diff --git a/contrib/rserv/CleanLog.in b/contrib/rserv/CleanLog.in
index 6fa1253de2ddc7272656866605d3cefab950f520..f15baea0b1833999863147f259021282e3320de9 100644 (file)
--- a/contrib/rserv/CleanLog.in
+++ b/contrib/rserv/CleanLog.in
@@ -38,6 +38,8 @@ print "Slave connection is $sinfo\n" if ($debug);
 
 my $conn = Pg::connectdb($minfo);
 
+$RServ::quiet = !$verbose;
+
 $res = CleanLog($conn, $howold);
 
 exit(1) if $res < 0;

diff --git a/contrib/rserv/GetSyncID.in b/contrib/rserv/GetSyncID.in
index d5b0755a2ea5d5dfba2fb0bcdec559457a92dd5c..10f4a93e47bc7871acc53de500278cc7cb8120b4 100644 (file)
--- a/contrib/rserv/GetSyncID.in
+++ b/contrib/rserv/GetSyncID.in
@@ -37,6 +37,8 @@ $sinfo = "$sinfo password=$opt_password" if (defined($opt_password));
 print("Connecting to '$sinfo'\n") if ($debug || $verbose);
 my $conn = Pg::connectdb($sinfo);
 
+$RServ::quiet = !$verbose;
+
 $res = GetSyncID($conn);
 
 die "ERROR\n" if $res < 0;

diff --git a/contrib/rserv/Makefile b/contrib/rserv/Makefile
index 272511974665631937de647035a9c0f393056adf..7a4cf72a57de0df516a3f6f16ad7252f235b262a 100644 (file)
--- a/contrib/rserv/Makefile
+++ b/contrib/rserv/Makefile
@@ -22,10 +22,10 @@ override DLLLIBS := $(BE_DLLLIBS) $(DLLLIBS)
 all: $(SQLS) $(TCLS) $(PERLS) $(SCRIPTS) $(SONAME)
 
 %.sql: %.sql.in
-   sed 's,@MODULE_FILENAME@,$$libdir/$(NAME),g' $< >$@
+   sed 's,@MODULE_FILENAME@,$(pkglibdir)/$(SONAME),g' $< >$@
 
 $(PERLS) $(TCLS) $(SCRIPTS): %: %.in
-   sed -e 's,@MODULE_FILENAME@,$$libdir/$(NAME),g' \
+   sed -e 's,@MODULE_FILENAME@,$(pkglibdir)/$(SONAME),g' \
        -e 's:@SQLDIR@:$(datadir)/contrib:g' \
        -e 's:@BINDIR@:$(bindir):g' \
        -e 's:@LIBDIR@:$(datadir)/contrib:g' $< >$@

diff --git a/contrib/rserv/MasterSync.in b/contrib/rserv/MasterSync.in
index abbe69ee0bf50ea2c760aabbd52c5e8885beb3e8..8328d78cc1db7424e450280cf1a9508c2bdf00d5 100644 (file)
--- a/contrib/rserv/MasterSync.in
+++ b/contrib/rserv/MasterSync.in
@@ -36,6 +36,8 @@ $minfo = "$minfo password=$opt_password" if (defined($opt_password));
 
 my $conn = Pg::connectdb($minfo);
 
+$RServ::quiet = !$verbose;
+
 $res = SyncSyncID($conn, $server, $syncid);
 
 if ($res == 0)

diff --git a/contrib/rserv/PrepareSnapshot.in b/contrib/rserv/PrepareSnapshot.in
index fe57ab949cc0e262e654ca32410a8ad8f9b24474..bd0fa237dc690aa7c9fd1e36fd9ad7871805bae2 100644 (file)
--- a/contrib/rserv/PrepareSnapshot.in
+++ b/contrib/rserv/PrepareSnapshot.in
@@ -39,6 +39,8 @@ my $conn = Pg::connectdb($minfo);
 my $outf = new IO::File;
 $outf = STDOUT;
 
+$RServ::quiet = !$verbose;
+
 $res = PrepareSnapshot ($conn, $outf, $server);
 
 if ($res == 0)

diff --git a/contrib/rserv/Replicate.in b/contrib/rserv/Replicate.in
index ccb9749b9308abe0d331b017be0a1f99bee81cd4..bd7c089a59756003f24c63d38f490cb5211415aa 100644 (file)
--- a/contrib/rserv/Replicate.in
+++ b/contrib/rserv/Replicate.in
@@ -49,6 +49,8 @@ print "Slave connection is $sinfo\n" if ($debug);
 my $mconn = Pg::connectdb($minfo);
 my $sconn = Pg::connectdb($sinfo);
 
+$RServ::quiet = !$verbose;
+
 SyncSync($mconn, $sconn);
 
 my $outf = new IO::File;