Fix lexing of U& sequences just before EOF.

Commit a5ff502fceadc7c203b0d7a11b45c73f1b421f69 was a brick shy of a load
in the backend lexer too, not just psql.  Per further testing of bug #9068.

In passing, improve related comments.

diff --git a/src/backend/parser/scan.l b/src/backend/parser/scan.l
index 68492204c777df00a2efb8e97d22db6f727ecb0b..e102e7c81e853a387c77b0a2ce42f46fedfa8427 100644 (file)
--- a/src/backend/parser/scan.l
+++ b/src/backend/parser/scan.l
@@ -155,6 +155,9 @@ extern void core_yyset_column(int column_no, yyscan_t yyscanner);
  *   quoted string with Unicode escapes
  *   end of a quoted string with Unicode escapes, UESCAPE can follow
  *   Unicode surrogate pair in extended quoted string
+ *
+ * Remember to add an <> case whenever you add a new exclusive state!
+ * The default one is probably not the right thing.
  */
 
 %x xb
@@ -545,12 +548,13 @@ other         .
 {quotefail} {
                    /* throw back all but the quote */
                    yyless(1);
-                   /* handle possible UESCAPE in xusend mode */
+                   /* xusend state looks for possible UESCAPE */
                    BEGIN(xusend);
                }
-{whitespace}
+{whitespace} { /* stay in xusend state over whitespace */ }
 {other} |
-{xustop1} {
+{xustop1} |
+<>    {
                    /* no UESCAPE after the quote, throw back everything */
                    yyless(0);
                    BEGIN(INITIAL);
@@ -725,12 +729,13 @@ other         .
                }
 {dquote} {
                    yyless(1);
-                   /* handle possible UESCAPE in xuiend mode */
+                   /* xuiend state looks for possible UESCAPE */
                    BEGIN(xuiend);
                }
-{whitespace} { }
+{whitespace} { /* stay in xuiend state over whitespace */ }
 {other} |
-{xustop1} {
+{xustop1} |
+<>    {
                    /* no UESCAPE after the quote, throw back everything */
                    char           *ident;
 

diff --git a/src/bin/psql/psqlscan.l b/src/bin/psql/psqlscan.l
index 7d61f932fdd6f02daa46c8c9305ea7696746c138..9231459755be6aad4aa8a0ea3797473d84cc87a6 100644 (file)
--- a/src/bin/psql/psqlscan.l
+++ b/src/bin/psql/psqlscan.l
@@ -166,7 +166,8 @@ static void escape_variable(bool as_ident);
  *   extended quoted strings (support backslash escape sequences)
  *   $foo$ quoted strings
  *   quoted identifier with Unicode escapes
- *   end of a quoted identifier with Unicode escapes, UESCAPE can follow *   quoted string with Unicode escapes
+ *   end of a quoted identifier with Unicode escapes, UESCAPE can follow
+ *   quoted string with Unicode escapes
  *   end of a quoted string with Unicode escapes, UESCAPE can follow
  *
  * Note: we intentionally don't mimic the backend's  state; we have