Allow NumericOnly to be "+ FCONST".

The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST,
FCONST, and - FCONST, but for some reason not + FCONST.  This led to
strange inconsistencies like

regression=# set random_page_cost = +4;
SET
regression=# set random_page_cost = 4000000000;
SET
regression=# set random_page_cost = +4000000000;
ERROR:  syntax error at or near "4000000000"

(because 4000000000 is too large to be an ICONST).  While there's
no actual functional reason to need to write a "+", if we allow
it for integers it seems like we should allow it for numerics too.

It's been like that forever, so back-patch to all supported branches.

Discussion: https://postgr.es/m/30908.1496006184@sss.pgh.pa.us

diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 411dbe2a6d2074768f8b6ec0c9ccd6f484a9e698..67e9a1a0c7dbeae571fa22af4372f66d1dbca765 100644 (file)
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -3670,6 +3670,7 @@ opt_by:       BY              {}
 
 NumericOnly:
            FCONST                              { $$ = makeFloat($1); }
+           | '+' FCONST                        { $$ = makeFloat($2); }
            | '-' FCONST
                {
                    $$ = makeFloat($2);