Honor PROVE_FLAGS environment setting

On MSVC builds and on back branches that means removing the hardcoded
--verbose setting. On master for Unix that means removing the empty
setting in the global Makefile so that the value can be acquired from
the environment as well as from the make arguments.

Backpatch to 9.4 where we introduced TAP tests

diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index 340e7441f45ebc01e60c6ad86e13c477a3e3ee10..8afc27bf0d3e89d94e9d6326829726fc08ea3cc4 100644 (file)
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -334,7 +334,8 @@ PROVE = @PROVE@
 # There are common routines in src/test/perl, and some test suites have
 # extra perl modules in their own directory.
 PG_PROVE_FLAGS = -I $(top_srcdir)/src/test/perl/ -I $(srcdir)
-PROVE_FLAGS = --verbose
+# User-supplied prove flags such as --verbose can be provided in PROVE_FLAGS.
+
 
 # prepend to path if already set, else just set it
 define add_to_path

diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
index bd1b607b001b7a31dcf3f6d97d5ddbd74858fb04..60a99f7ceb10e79b0ca0ff5b333dfb9571eac529 100644 (file)
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -179,7 +179,10 @@ sub tap_check
    my $dir = shift;
    chdir $dir;
 
-   my @args = ( "prove", "--verbose", "t/*.pl");
+   my @flags;
+   @flags = split(/\s+/,$ENV{PROVE_FLAGS}) if exists $ENV{PROVE_FLAGS};
+
+   my @args = ("prove", @flags, "t/*.pl");
 
    # adjust the environment for just this test
    local %ENV = %ENV;