Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.
authorAndres Freund
Tue, 9 Jun 2020 02:52:19 +0000 (19:52 -0700)
committerAndres Freund
Tue, 9 Jun 2020 03:02:56 +0000 (20:02 -0700)
commitfd6daa006e7ba42c0f97fe852d83293e5e34d15c
tree67a9eba1450cf01a19f0fb03819a48db15bebaa2
parent48eb6a3c895dac239f7e04fc3d62c09a17c1fc4a
Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.

Previously we used pg_atomic_write_64_impl inside
pg_atomic_init_u64. That works correctly, but on platforms without
64bit single copy atomicity it could trigger spurious valgrind errors
about uninitialized memory, because we use compare_and_swap for atomic
writes on such platforms.

I previously suppressed one instance of this problem (6c878edc1df),
but as Tom reports that wasn't enough. As the atomic variable cannot
yet be concurrently accessible during initialization, it seems better
to have pg_atomic_init_64_impl set the value directly.

Change pg_atomic_init_u32_impl for symmetry.

Reported-By: Tom Lane
Author: Andres Freund
Discussion: https://postgr.es/m/1714601.1591503815@sss.pgh.pa.us
Backpatch: 9.5-
src/include/port/atomics/generic.h
src/tools/valgrind.supp