Use snprintf not sprintf in pg_waldump's timestamptz_to_str.
authorTom Lane
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
committerTom Lane
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
commitfd079dd0915a2005da2fbfd75fda1cc3611f3a2f
tree28a3a199eae9ddd2c5a4afd4857c71bbf6900e82
parent817f9f9a8a1932a0cd8c6bc5c9d3e77f6a80e659
Use snprintf not sprintf in pg_waldump's timestamptz_to_str.

This could only cause an issue if strftime returned a ridiculously
long timezone name, which seems unlikely; and it wouldn't qualify
as a security problem even then, since pg_waldump (nee pg_xlogdump)
is a debug tool not part of the server.  But gcc 8 has started issuing
warnings about it, so let's use snprintf and be safe.

Backpatch to 9.3 where this code was added.

Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us
contrib/pg_xlogdump/compat.c