Convert uses of hash_string_pointer to fasthash equivalent
authorJohn Naylor
Sat, 6 Apr 2024 05:17:07 +0000 (12:17 +0700)
committerJohn Naylor
Sat, 6 Apr 2024 05:20:40 +0000 (12:20 +0700)
commitf956ecd0353b2960f8322b2211142113fe2b6f67
tree19ba604fb7f7cf34f3fcfbb4349810cb26a29030
parentdb17594ad73a871a176a9bf96e0589c2cf57052c
Convert uses of hash_string_pointer to fasthash equivalent

Remove duplicate hash_string_pointer() function definitions by creating
a new inline function hash_string() for this purpose.

This has the added advantage of avoiding strlen() calls when doing hash
lookup. It's not clear how many of these are perfomance-sensitive
enough to benefit from that, but the simplification is worth it on
its own.

Reviewed by Jeff Davis

Discussion: https://postgr.es/m/CANWCAZbg_XeSeY0a_PqWmWqeRATvzTzUNYRLeT%2Bbzs%2BYQdC92g%40mail.gmail.com
src/bin/pg_combinebackup/load_manifest.c
src/bin/pg_dump/pg_dumpall.c
src/bin/pg_rewind/filemap.c
src/bin/pg_verifybackup/pg_verifybackup.c
src/include/common/hashfn_unstable.h