For PowerPC instruction "addi", use constraint "b".
authorNoah Misch
Sat, 19 Oct 2019 03:20:28 +0000 (20:20 -0700)
committerNoah Misch
Sat, 19 Oct 2019 03:20:31 +0000 (20:20 -0700)
commitef13f914e6c2a66f186f73ec1bba682e56dc621b
tree3f8a3704b071255fee499c588480660a7b278ac9
parent9dfbf9a04398f8b9332d95e49037c530c4dda827
For PowerPC instruction "addi", use constraint "b".

Without "b", a variant of the tas() code miscompiles on macOS 10.4.
This may also fix a compilation failure involving macOS 10.1.  Today's
compilers have been allocating acceptable registers with or without this
change, but this future-proofs the code by precisely conveying the
acceptable registers.  Back-patch to 9.4 (all supported versions).

Reviewed by Tom Lane.

Discussion: https://postgr.es/m/20191009063900[email protected]
src/include/storage/s_lock.h