Fix assert failures in parallel SERIALIZABLE READ ONLY.
authorThomas Munro
Mon, 6 Mar 2023 02:07:15 +0000 (15:07 +1300)
committerThomas Munro
Mon, 6 Mar 2023 03:17:22 +0000 (16:17 +1300)
commite9051ecd58e9f171c5c92f28c1bbd8f42fa243c1
tree3e4828d8eb8b34a586b1e29769c9e1d50df101d5
parent5ad63eee13e70eeff9659bcee024e8249b6bf68c
Fix assert failures in parallel SERIALIZABLE READ ONLY.

1.  Make sure that we don't decrement SxactGlobalXminCount twice when
the SXACT_FLAG_RO_SAFE optimization is reached in a parallel query.
This could trigger a sanity check failure in assert builds.  Non-assert
builds recompute the count in SetNewSxactGlobalXmin(), so the problem
was hidden, explaining the lack of field reports.  Add a new isolation
test to exercise that case.

2.  Remove an assertion that the DOOMED flag can't be set on a partially
released SERIALIZABLEXACT.  Instead, ignore the flag (our transaction
was already determined to be read-only safe, and DOOMED is in fact set
during partial release, and there was already an assertion that it
wasn't set sooner).  Improve an existing isolation test so that it
reaches that case (previously it wasn't quite testing what it was
supposed to be testing; see discussion).

Back-patch to 12.  Bug #17116.  Defects in commit 47a338cf.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/17116-d6ca217acc180e30%40postgresql.org
src/backend/storage/lmgr/predicate.c
src/test/isolation/expected/serializable-parallel-2.out
src/test/isolation/expected/serializable-parallel-3.out [new file with mode: 0644]
src/test/isolation/isolation_schedule
src/test/isolation/specs/serializable-parallel-2.spec
src/test/isolation/specs/serializable-parallel-3.spec [new file with mode: 0644]