ecpg: Fix zero-termination of string generated by intoasc()
authorMichael Paquier
Mon, 19 Feb 2024 02:38:18 +0000 (11:38 +0900)
committerMichael Paquier
Mon, 19 Feb 2024 02:38:18 +0000 (11:38 +0900)
commite77a1c58e338a1aebf00e3ae82d282f8bd32fe17
tree5d2d7e9d2a109a550871359da7de38964d92caad
parent0a9118ccc0eb2e6a31201b2443a2eb1078e34894
ecpg: Fix zero-termination of string generated by intoasc()

intoasc(), a wrapper for PGTYPESinterval_to_asc that converts an
interval to its textual representation, used a plain memcpy() when
copying its result.  This could miss a zero-termination in the result
string, leading to an incorrect result.

The routines in informix.c do not provide the length of their result
buffer, which would allow a replacement of strcpy() to safer strlcpy()
calls, but this requires an ABI breakage and that cannot happen in
back-branches.

Author: Oleg Tselebrovskiy
Reviewed-by: Ashutosh Bapat
Discussion: https://postgr.es/m/bf47888585149f83b276861a1662f7e4@postgrespro.ru
Backpatch-through: 12
src/interfaces/ecpg/compatlib/informix.c
src/interfaces/ecpg/test/compat_informix/.gitignore
src/interfaces/ecpg/test/compat_informix/Makefile
src/interfaces/ecpg/test/compat_informix/intoasc.pgc [new file with mode: 0644]
src/interfaces/ecpg/test/compat_informix/meson.build
src/interfaces/ecpg/test/ecpg_schedule
src/interfaces/ecpg/test/expected/compat_informix-intoasc.c [new file with mode: 0644]
src/interfaces/ecpg/test/expected/compat_informix-intoasc.stderr [new file with mode: 0644]
src/interfaces/ecpg/test/expected/compat_informix-intoasc.stdout [new file with mode: 0644]