Rename lo_create(oid, bytea) to lo_from_bytea().
authorTom Lane
Thu, 12 Jun 2014 19:39:09 +0000 (15:39 -0400)
committerTom Lane
Thu, 12 Jun 2014 19:39:16 +0000 (15:39 -0400)
commite3489847d08beaa4b9dc2a84011719f0b848f3e1
tree131379545d0a2223eed246c735f8fcaf73a5e44a
parentd52a6c4944c1d83cfaae53e20561c53220e7968b
Rename lo_create(oid, bytea) to lo_from_bytea().

The previous naming broke the query that libpq's lo_initialize() uses
to collect the OIDs of the server-side functions it requires, because
that query effectively assumes that there is only one function named
lo_create in the pg_catalog schema (and likewise only one lo_open, etc).

While we should certainly make libpq more robust about this, the naive
query will remain in use in the field for the foreseeable future, so it
seems the only workable choice is to use a different name for the new
function.  lo_from_bytea() won a small straw poll.

Back-patch into 9.4 where the new function was introduced.
doc/src/sgml/lobj.sgml
src/backend/libpq/be-fsstubs.c
src/include/catalog/catversion.h
src/include/catalog/pg_proc.h
src/include/libpq/be-fsstubs.h
src/test/regress/input/largeobject.source
src/test/regress/output/largeobject.source
src/test/regress/output/largeobject_1.source