Add missing bad-PGconn guards in libpq entry points.
authorTom Lane
Mon, 15 Aug 2022 19:40:07 +0000 (15:40 -0400)
committerTom Lane
Mon, 15 Aug 2022 19:40:07 +0000 (15:40 -0400)
commitd63a69157d189bf3d56eb5ad37fa67d0134bfb31
treed5491d34c19d7e4711ec7dfd65083603a852a368
parent63b64d8270691894a9a8f2d4e929e7780020edb8
Add missing bad-PGconn guards in libpq entry points.

There's a convention that externally-visible libpq functions should
check for a NULL PGconn pointer, and fail gracefully instead of
crashing.  PQflush() and PQisnonblocking() didn't get that memo
though.  Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL;
while it's not clear that ordinary usage could reach that with a
null conn pointer, it's cheap enough to check, so let's be consistent.

Daniele Varrazzo and Tom Lane

Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com
src/interfaces/libpq/fe-exec.c
src/interfaces/libpq/fe-secure-openssl.c