pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.
authorAndres Freund
Wed, 30 Oct 2019 05:46:40 +0000 (22:46 -0700)
committerAndres Freund
Wed, 30 Oct 2019 05:53:30 +0000 (22:53 -0700)
commitd4b5206b22374ddf99dbe31370d6d713881fb87c
tree7c43f4bd20e33fe3a0cb0d40e0d5f5d321db79f5
parent4ab353c477e6f585973b171a2652551574cbbc45
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341[email protected]
Backpatch: 9.5, like 2c03216d831.
src/bin/pg_waldump/pg_waldump.c