Disallow starting server with insufficient wal_level for existing slot.
authorAndres Freund
Wed, 31 Oct 2018 21:47:41 +0000 (14:47 -0700)
committerAndres Freund
Wed, 31 Oct 2018 22:46:40 +0000 (15:46 -0700)
commitd35fd17cb58db72122912b57c75c8825ebf24285
tree42a159b248dcbfe153bc4823d48a23123c233c57
parent558571afc7c42c47243836c411ad86fc6c0577c5
Disallow starting server with insufficient wal_level for existing slot.

Previously it was possible to create a slot, change wal_level, and
restart, even if the new wal_level was insufficient for the
slot. That's a problem for both logical and physical slots, because
the necessary WAL records are not generated.

This removes a few tests in newer versions that, somewhat
inexplicably, whether restarting with a too low wal_level worked (a
buggy behaviour!).

Reported-By: Joshua D. Drake
Author: Andres Freund
Discussion: https://postgr.es/m/20181029191304[email protected]
Backpatch: 9.4-, where replication slots where introduced
src/backend/replication/logical/logical.c
src/backend/replication/slot.c