Make sure that hash join's bulk-tuple-transfer loops are interruptible.
authorTom Lane
Wed, 15 Feb 2017 21:40:06 +0000 (16:40 -0500)
committerTom Lane
Wed, 15 Feb 2017 21:40:06 +0000 (16:40 -0500)
commitd0e9c0e3199cefb36dc787293f577cd57b984bfe
treeed1d7c91d6788843b74e910857630955a75db214
parent804aad8ff46cbef9f520507bb8b4522a011cd1b2
Make sure that hash join's bulk-tuple-transfer loops are interruptible.

The loops in ExecHashJoinNewBatch(), ExecHashIncreaseNumBatches(), and
ExecHashRemoveNextSkewBucket() are all capable of iterating over many
tuples without ever doing a CHECK_FOR_INTERRUPTS, so that the backend
might fail to respond to SIGINT or SIGTERM for an unreasonably long time.
Fix that.  In the case of ExecHashJoinNewBatch(), it seems useful to put
the added CHECK_FOR_INTERRUPTS into ExecHashJoinGetSavedTuple() rather
than directly in the loop, because that will also ensure that both
principal code paths through ExecHashJoinOuterGetTuple() will do a
CHECK_FOR_INTERRUPTS, which seems like a good idea to avoid surprises.

Back-patch to all supported branches.

Tom Lane and Thomas Munro

Discussion: https://postgr.es/m/6044.1487121720@sss.pgh.pa.us
src/backend/executor/nodeHash.c
src/backend/executor/nodeHashjoin.c