Avoid unhelpful internal error for incorrect recursive-WITH queries.
authorTom Lane
Sun, 14 Jul 2024 17:49:46 +0000 (13:49 -0400)
committerTom Lane
Sun, 14 Jul 2024 17:49:46 +0000 (13:49 -0400)
commitcf588e10f664be37a0804e9a8662facd0e163800
tree427bdb1d463f7da94b358b47fb08a31a386902ab
parent5ea9f66616801d0b4be6ce49c74e45bb4f325359
Avoid unhelpful internal error for incorrect recursive-WITH queries.

checkWellFormedRecursion would issue "missing recursive reference"
if a WITH RECURSIVE query contained a single self-reference but
that self-reference was inside a top-level WITH, ORDER BY, LIMIT,
etc, rather than inside the second arm of the UNION as expected.
We already intended to throw more-on-point errors for such cases,
but those error checks must be done before examining the UNION arm
in order to have the desired results.  So this patch need only
move some code (and improve the comments).

Per bug #18536 from Alexander Lakhin.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/18536-0a342ec07901203e@postgresql.org
src/backend/parser/parse_cte.c
src/test/regress/expected/with.out
src/test/regress/sql/with.sql