Stabilize pg_dump output order for similarly-named triggers and policies.
authorTom Lane
Mon, 4 Nov 2019 21:25:05 +0000 (16:25 -0500)
committerTom Lane
Mon, 4 Nov 2019 21:25:05 +0000 (16:25 -0500)
commitca27a84c98f0d071d527bfd17f500a0bd66cb4d2
treee7037943ba013430bd04272164fc9a61d54b2f48
parent5a2967412f63f3b9390aa7b3af95e2fae0965ff8
Stabilize pg_dump output order for similarly-named triggers and policies.

The code only compared two triggers' names and namespaces (the latter
being the owning table's schema).  This could result in falling back
to an OID-based sort of similarly-named triggers on different tables.
We prefer to avoid that, so add a comparison of the table names too.
(The sort order is thus table namespace, trigger name, table name,
which is a bit odd, but it doesn't seem worth contorting the code
to work around that.)

Likewise for policy objects, in 9.5 and up.

Complaint and fix by Benjie Gillam.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CAMThMzEEt2mvBbPgCaZ1Ap1N-moGn=Edxmadddjq89WG4NpPtQ@mail.gmail.com
src/bin/pg_dump/pg_dump_sort.c