Use pgBufferUsage for buffer usage tracking in analyze.
authorMasahiko Sawada
Wed, 14 Aug 2024 01:49:45 +0000 (18:49 -0700)
committerMasahiko Sawada
Wed, 14 Aug 2024 01:49:45 +0000 (18:49 -0700)
commitc584781bcc686ebc0b3139e3e166607537336f69
tree6394b70a67de08a11ed515cdda2ce75d6c6cbbfa
parent2488058dc356a43455b21a099ea879fff9266634
Use pgBufferUsage for buffer usage tracking in analyze.

Previously, (auto)analyze used global variables VacuumPageHit,
VacuumPageMiss, and VacuumPageDirty to track buffer usage. However,
pgBufferUsage provides a more generic way to track buffer usage with
support functions.

This change replaces those global variables with pgBufferUsage in
analyze. Since analyze was the sole user of those variables, it
removes their declarations. Vacuum previously used those variables but
replaced them with pgBufferUsage as part of a bug fix, commit
5cd72cc0c.

Additionally, it adjusts the buffer usage message in both vacuum and
analyze for better consistency.

Author: Anthonin Bonnefoy
Reviewed-by: Masahiko Sawada, Michael Paquier
Discussion: https://postgr.es/m/CAO6_Xqr__kTTCLkftqS0qSCm-J7_xbRG3Ge2rWhucxQJMJhcRA%40mail.gmail.com
src/backend/access/heap/vacuumlazy.c
src/backend/commands/analyze.c
src/backend/commands/vacuum.c
src/backend/commands/vacuumparallel.c
src/backend/storage/buffer/bufmgr.c
src/backend/utils/init/globals.c
src/include/miscadmin.h