Fix TestLib::slurp_file() with offset on windows.
authorAndres Freund
Mon, 4 Oct 2021 20:28:06 +0000 (13:28 -0700)
committerAndres Freund
Mon, 4 Oct 2021 20:28:48 +0000 (13:28 -0700)
commitc4465cd09e3ab034ced25e623d5760e9ce437f6c
tree40ee2b72837cefd8e0fe4ebde0db2ad4beb51c70
parent919c08d909f766bb51c5c617714364a91bb90d9d
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan
Author: Andres Freund 
Discussion: https://postgr.es/m/20211003173038[email protected]
Backpatch: 9.6-, like 3c5b0685b921
src/test/perl/TestLib.pm