Disallow a digit as the first character of a variable name in pgbench.
authorTom Lane
Wed, 13 Jan 2021 19:52:49 +0000 (14:52 -0500)
committerTom Lane
Wed, 13 Jan 2021 19:52:59 +0000 (14:52 -0500)
commitc21ea4d53e9404279273da800daa49b7b9a5e81e
tree7880d8a335ed970459d48064deac74f30b29184f
parent5abca4b1cd7193d6a5c8235c97eb240312190bcb
Disallow a digit as the first character of a variable name in pgbench.

The point of this restriction is to avoid trying to substitute variables
into timestamp literal values, which may contain strings like '12:34'.

There is a good deal more that should be done to reduce pgbench's
tendency to substitute where it shouldn't.  But this is sufficient to
solve the case complained of by Jaime Soler, and it's simple enough
to back-patch.

Back-patch to v11; before commit 9d36a3866, pgbench had a slightly
different definition of what a variable name is, and anyway it seems
unwise to change long-stable branches for this.

Fabien Coelho

Discussion: https://postgr.es/m/alpine.DEB.2.22.394.2006291740420.805678@pseudo
doc/src/sgml/ref/pgbench.sgml
src/bin/pgbench/pgbench.c