Fix usage of aggregate pathkeys in group_keys_reorder_by_pathkeys()
authorAlexander Korotkov
Fri, 9 Feb 2024 10:56:26 +0000 (12:56 +0200)
committerAlexander Korotkov
Fri, 9 Feb 2024 10:56:54 +0000 (12:56 +0200)
commitc01f6ef46c8f0ab3faa54e8f040da6e9ddc7fe5b
treed4754056f3d78f249135997e04d86d128a505369
parent6743c5ae64e3c957ef8bd4f8a0daa2ba9959b0b3
Fix usage of aggregate pathkeys in group_keys_reorder_by_pathkeys()

group_keys_reorder_by_pathkeys() function searched for matching pathkeys
within root->group_pathkeys.  That could lead to picking an aggregate pathkey
and using its pathkey->pk_eclass->ec_sortref as an argument of
get_sortgroupref_clause_noerr().  Given that ec_sortref of an aggregate pathkey
references aggregate targetlist not query targetlist, this leads to incorrect
query optimization.

Fix this by looking for matching pathkeys only within the first
num_groupby_pathkeys pathkeys.

Reported-by: David G. Johnston
Discussion: https://postgr.es/m/CAKFQuwY3Ek%3DcLThgd8FdaSc5JRDVt0FaV00gMcWra%2BTAR4gGUw%40mail.gmail.com
Author: Andrei Lepikhov, Alexander Korotkov
src/backend/optimizer/path/pathkeys.c
src/test/regress/expected/aggregates.out
src/test/regress/sql/aggregates.sql