Fix multiple minor infelicities in aclchk.c error reports.
authorTom Lane
Mon, 13 Jun 2016 17:53:10 +0000 (13:53 -0400)
committerTom Lane
Mon, 13 Jun 2016 17:53:10 +0000 (13:53 -0400)
commitba6421808b61340a16df566beea0d6d81b10124c
tree9514ed79371953b0f944f8e9d433e1e1f48bdb4d
parentd9ce54c0b83506473828444c30a96e3e2601fe7d
Fix multiple minor infelicities in aclchk.c error reports.

pg_type_aclmask reported the wrong type's OID when complaining that
it could not find a type's typelem.  It also failed to provide a
suitable errcode when the initially given OID doesn't exist (which
is a user-facing error, since that OID can be user-specified).
pg_foreign_data_wrapper_aclmask and pg_foreign_server_aclmask likewise
lacked errcode specifications.  Trivial cosmetic adjustments too.

The wrong-type-OID problem was reported by Petru-Florin Mihancea in
bug #14186; the other issues noted by me while reading the code.
These errors all seem to be aboriginal in the respective routines, so
back-patch as necessary.

Report: <20160613163159[email protected]>
src/backend/catalog/aclchk.c