Prevent underflow in KeepLogSeg().
authorNathan Bossart
Thu, 27 Apr 2023 20:43:48 +0000 (13:43 -0700)
committerNathan Bossart
Thu, 27 Apr 2023 21:31:17 +0000 (14:31 -0700)
commitb72623671d9c0ead4ac219c69762246073fe2185
tree782f73dee2dac1f8cf9289f0d3e8f9654e8ab9cb
parentdb93e739ac61332126207b16f14da93f8ecac594
Prevent underflow in KeepLogSeg().

The call to XLogGetReplicationSlotMinimumLSN() might return a
greater LSN than the one given to the function.  Subsequent segment
number calculations might then underflow, which could result in
unexpected behavior when removing or recyling WAL files.  This was
introduced with max_slot_wal_keep_size in c655077639.  To fix, skip
the block of code for replication slots if the LSN is greater.

Reported-by: Xu Xingwang
Author: Kyotaro Horiguchi
Reviewed-by: Junwang Zhao
Discussion: https://postgr.es/m/17903-4288d439dee856c6%40postgresql.org
Backpatch-through: 13
src/backend/access/transam/xlog.c