Fix unobvious interaction between -X switch and subdirectory creation.
authorTom Lane
Thu, 7 Jan 2016 23:20:57 +0000 (18:20 -0500)
committerTom Lane
Thu, 7 Jan 2016 23:20:57 +0000 (18:20 -0500)
commitaa062597c5192fdd758900eb3740a5bd935feda9
tree8a4f4ecb7d9c669f54f35351d8006403ec380fb4
parent33b051293a40b138c1ac02cdd1425977977dcd1d
Fix unobvious interaction between -X switch and subdirectory creation.

Turns out the only reason initdb -X worked is that pg_mkdir_p won't
whine if you point it at something that's a symlink to a directory.
Otherwise, the attempt to create pg_xlog/ just like all the other
subdirectories would have failed.  Let's be a little more explicit
about what's happening.  Oversight in my patch for bug #13853
(mea culpa for not testing -X ...)
src/bin/initdb/initdb.c