Fix handling of R/W expanded datums that are passed to SQL functions.
authorTom Lane
Wed, 10 Aug 2022 17:37:25 +0000 (13:37 -0400)
committerTom Lane
Wed, 10 Aug 2022 17:37:25 +0000 (13:37 -0400)
commit95bfadd4e83c17f1a31ab97eb2aba44a38c36324
treecfe7cb45a3ef73d52e378de279ccaa43967e4e32
parent278273ccbad27a8834dfdf11895da9cd91de4114
Fix handling of R/W expanded datums that are passed to SQL functions.

fmgr_sql must make expanded-datum arguments read-only, because
it's possible that the function body will pass the argument to
more than one callee function.  If one of those functions takes
the datum's R/W property as license to scribble on it, then later
callees will see an unexpected value, leading to wrong answers.

From a performance standpoint, it'd be nice to skip this in the
common case that the argument value is passed to only one callee.
However, detecting that seems fairly hard, and certainly not
something that I care to attempt in a back-patched bug fix.

Per report from Adam Mackler.  This has been broken since we
invented expanded datums, so back-patch to all supported branches.

Discussion: https://postgr.es/m/WScDU5qfoZ7PB2gXwNqwGGgDPmWzz08VdydcPFLhOwUKZcdWbblbo-0Lku-qhuEiZoXJ82jpiQU4hOjOcrevYEDeoAvz6nR0IU4IHhXnaCA=@mackler.email
Discussion: https://postgr.es/m/187436.1660143060@sss.pgh.pa.us
src/backend/executor/functions.c
src/test/regress/expected/create_function_3.out
src/test/regress/sql/create_function_3.sql