Fix the random test failure in 001_rep_changes.
authorAmit Kapila
Wed, 1 Sep 2021 04:48:23 +0000 (10:18 +0530)
committerAmit Kapila
Wed, 1 Sep 2021 04:48:23 +0000 (10:18 +0530)
commit8d0138ef51b51ba3e419cf49069eb72a15f74706
tree1496251c87dd20147f26fdaae70a54914824de4f
parentb175b9cde720a81852b70c0c7fbc18c72ff1acc6
Fix the random test failure in 001_rep_changes.

The check to test whether the subscription workers were restarting after a
change in the subscription was failing. The reason was that the test was
assuming the walsender started before it reaches the 'streaming' state and
the walsender was exiting due to an error before that. Now, the walsender
was erroring out before reaching the 'streaming' state because it tries to
acquire the slot before the previous walsender has exited.

In passing, improve the die messages so that it is easier to investigate
the failures in the future if any.

Reported-by: Michael Paquier, as per buildfarm
Author: Ajin Cherian
Reviewed-by: Masahiko Sawada, Amit Kapila
Backpatch-through: 10, where this test was introduced
Discussion: https://postgr.es/m/[email protected]
src/test/subscription/t/001_rep_changes.pl
src/test/subscription/t/022_twophase_cascade.pl