pg_stat_activity: show NULL stmt start time for walsenders
authorAlvaro Herrera
Tue, 7 Jan 2020 20:38:48 +0000 (17:38 -0300)
committerAlvaro Herrera
Tue, 7 Jan 2020 20:38:48 +0000 (17:38 -0300)
commit896db774e5b0a851792f02c8a19ea9b07c9dcc23
tree7f3295d3f58d98d2f2e4ee95c7c698d2c8ba322b
parent7474393e0b98971c7779cbb23c2d7d17e38a944c
pg_stat_activity: show NULL stmt start time for walsenders

Returning a non-NULL time is pointless, sinc a walsender is not a
process that would be running normal transactions anyway, but the code
was unintentionally exposing the process start time intermittently,
which was not only bogus but it also confused monitoring systems looking
for idle transactions.  Fix by avoiding all updates in walsenders.

Backpatch to 11, where walsenders started appearing in pg_stat_activity.

Reported-by: Tomas Vondra
Discussion: https://postgr.es/m/20191209234409.exe7osmyalwkt5j4@development
src/backend/access/transam/xact.c