Advance old-segment horizon properly after slot invalidation
authorAlvaro Herrera
Fri, 16 Jul 2021 16:07:30 +0000 (12:07 -0400)
committerAlvaro Herrera
Fri, 16 Jul 2021 16:07:30 +0000 (12:07 -0400)
commit866237a6fa01a128325df41ad39b41ea3363c9a9
tree03933ce1e62cd206dd1d74da6078240e5e30ce4b
parent91a1651057b15809058acb174fead131ef8efab8
Advance old-segment horizon properly after slot invalidation

When some slots are invalidated due to the max_slot_wal_keep_size limit,
the old segment horizon should move forward to stay within the limit.
However, in commit c6550776394e we forgot to call KeepLogSeg again to
recompute the horizon after invalidating replication slots.  In cases
where other slots remained, the limits would be recomputed eventually
for other reasons, but if all slots were invalidated, the limits would
not move at all afterwards.  Repair.

Backpatch to 13 where the feature was introduced.

Author: Kyotaro Horiguchi 
Reported-by: Marcin Krupowicz
Discussion: https://postgr.es/m/17103-004130e8f27782c9@postgresql.org
src/backend/access/transam/xlog.c
src/backend/replication/slot.c
src/include/replication/slot.h
src/test/recovery/t/019_replslot_limit.pl