Avoid trying to lock OLD/NEW in a rule with FOR UPDATE.
authorTom Lane
Thu, 19 Aug 2021 16:12:35 +0000 (12:12 -0400)
committerTom Lane
Thu, 19 Aug 2021 16:12:35 +0000 (12:12 -0400)
commit7fa367d96bb1ae25f422d6c2a78424f0f9227b5a
treed27dfe4d020d1521c9af1e862c003273df6c300c
parentecd4dd9f1df00ef9e872a4d13bbbe3f3d8d3f966
Avoid trying to lock OLD/NEW in a rule with FOR UPDATE.

transformLockingClause neglected to exclude the pseudo-RTEs for
OLD/NEW when processing a rule's query.  This led to odd errors
or even crashes later on.  This bug is very ancient, but it's
not terribly surprising that nobody noticed, since the use-case
for SELECT FOR UPDATE in a non-view rule is somewhere between
thin and non-existent.  Still, crashing is not OK.

Per bug #17151 from Zhiyong Wu.  Thanks to Masahiko Sawada
for analysis of the problem.

Discussion: https://postgr.es/m/17151-c03a3e6e4ec9aadb@postgresql.org
src/backend/parser/analyze.c
src/include/nodes/parsenodes.h
src/test/regress/expected/rules.out
src/test/regress/sql/rules.sql