Fix incorrect logic for excluding range constructor functions in pg_dump.
authorTom Lane
Fri, 23 Sep 2016 17:49:26 +0000 (13:49 -0400)
committerTom Lane
Fri, 23 Sep 2016 17:49:26 +0000 (13:49 -0400)
commit7e02476f337990e68c80b7a1395dcc6af111c034
treed2b35c91c75c9090d6d22ad62d889bf3921406cd
parenta20435fe9aa52cd8c62f3b0ed359077a56824830
Fix incorrect logic for excluding range constructor functions in pg_dump.

Faulty AND/OR nesting in the WHERE clause of getFuncs' SQL query led to
dumping range constructor functions if they are part of an extension
and we're in binary-upgrade mode.  Actually, we don't want to dump them
separately even then, since CREATE TYPE AS RANGE will create the range's
constructor functions regardless.  Per report from Andrew Dunstan.

It looks like this mistake was introduced by me, in commit b985d4877, in
perhaps-overzealous refactoring to reduce code duplication.  I'm suitably
embarrassed.

Report: <34854939-02d7-f591-5677-ce2994104599@dunslane.net>
src/bin/pg_dump/pg_dump.c