Fix toast rewrites in logical decoding.
authorAmit Kapila
Wed, 25 Aug 2021 03:53:27 +0000 (09:23 +0530)
committerAmit Kapila
Wed, 25 Aug 2021 03:53:27 +0000 (09:23 +0530)
commit794025eff0db181e463cb92d4b1aedd0879c88a6
treea8a1237e4c71c139229cd3ee655d476f7172150b
parent7d9026cbfd340a4de6c96ff7c728e53c3791e1cc
Fix toast rewrites in logical decoding.

Commit 325f2ec555 introduced pg_class.relwrite to skip operations on
tables created as part of a heap rewrite during DDL. It links such
transient heaps to the original relation OID via this new field in
pg_class but forgot to do anything about toast tables. So, logical
decoding was not able to skip operations on internally created toast
tables. This leads to an error when we tried to decode the WAL for the
next operation for which it appeared that there is a toast data where
actually it didn't have any toast data.

To fix this, we set pg_class.relwrite for internally created toast tables
as well which allowed skipping operations on them during logical decoding.

Author: Bertrand Drouvot
Reviewed-by: David Zhang, Amit Kapila
Backpatch-through: 11, where it was introduced
Discussion: https://postgr.es/m/b5146fb1-ad9e-7d6e-f980-98ed68744a7c@amazon.com
contrib/test_decoding/expected/toast.out
contrib/test_decoding/sql/toast.sql
src/backend/catalog/toasting.c
src/backend/commands/cluster.c
src/backend/commands/tablecmds.c
src/include/catalog/toasting.h
src/include/commands/tablecmds.h