Correct type of front_pathkey to PathKey
authorTomas Vondra
Sun, 23 Jan 2022 02:36:55 +0000 (03:36 +0100)
committerTomas Vondra
Sun, 23 Jan 2022 03:05:08 +0000 (04:05 +0100)
commit72ac4d71b54fdac5efc9ecfc23663f26c20ddcf9
tree2d5e366382a0b4bd92b3d5b9f3fd2fc704724724
parenta192243c75be0f142f829b3e73548bc7cbd3b90d
Correct type of front_pathkey to PathKey

In sort_inner_and_outer we iterate a list of PathKey elements, but the
variable is declared as (List *). This mistake is benign, because we
only pass the pointer to lcons() and never dereference it.

This exists since ~2004, but it's confusing. So fix and backpatch to all
supported branches.

Backpatch-through: 10
Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com
src/backend/optimizer/path/joinpath.c