Fix unsafe access to BufferDescriptors
authorRichard Guo
Wed, 19 Feb 2025 02:05:35 +0000 (11:05 +0900)
committerRichard Guo
Wed, 19 Feb 2025 02:05:35 +0000 (11:05 +0900)
commit71d02dc478d574c75bd0af82cec774c7b9059a61
tree8dd41622bc04fcde9b4cf10fb605948ed513515f
parentc39392ebaeeff7dafbc255844bcc605aaef01d7d
Fix unsafe access to BufferDescriptors

When considering a local buffer, the GetBufferDescriptor() call in
BufferGetLSNAtomic() would be retrieving a shared buffer with a bad
buffer ID.  Since the code checks whether the buffer is shared before
using the retrieved BufferDesc, this issue did not lead to any
malfunction.  Nonetheless this seems like trouble waiting to happen,
so fix it by ensuring that GetBufferDescriptor() is only called when
we know the buffer is shared.

Author: Tender Wang 
Reviewed-by: Xuneng Zhou
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/CAHewXNku-o46-9cmUgyv6LkSZ25doDrWq32p=oz9kfD8ovVJMg@mail.gmail.com
Backpatch-through: 13
src/backend/storage/buffer/bufmgr.c