Further second thoughts about idle_session_timeout patch.
authorTom Lane
Thu, 7 Jan 2021 16:45:09 +0000 (11:45 -0500)
committerTom Lane
Thu, 7 Jan 2021 16:45:09 +0000 (11:45 -0500)
commit5db4fdc22472919f97ce83d276fb34b47c794d1f
treea5a7f9b1f7b6a3d7bdbcda1345f46d94ad1b5434
parent0f8977b3f2536c91a0a97e2395c297d3acf1f491
Further second thoughts about idle_session_timeout patch.

On reflection, the order of operations in PostgresMain() is wrong.
These timeouts ought to be shut down before, not after, we do the
post-command-read CHECK_FOR_INTERRUPTS, to guarantee that any
timeout error will be detected there rather than at some ill-defined
later point (possibly after having wasted a lot of work).

This is really an error in the original idle_in_transaction_timeout
patch, so back-patch to 9.6 where that was introduced.
src/backend/tcop/postgres.c