Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs.
authorTom Lane
Mon, 29 May 2017 21:08:16 +0000 (17:08 -0400)
committerTom Lane
Mon, 29 May 2017 21:08:16 +0000 (17:08 -0400)
commit5bcbc4cd6d9ca29fe3da9c609bfeb5357982a4e9
tree46b15bafc6b9ac3a6c35268a182b2d555e668fb3
parent096221e85d36ccf66aa5e9e867acd00385b1d9d8
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs.

pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching
version number in pg_control, and that seems like an important thing to
preserve since recovering from corrupt pg_control is a prime reason to
need to run it.  However, that means you can try to run it against a
data directory of a different major version, which is at best useless
and at worst disastrous.  So as to provide some protection against that
type of pilot error, inspect PG_VERSION at startup and refuse to do
anything if it doesn't match.  PG_VERSION is read-only after initdb,
so it's unlikely to get corrupted, and even if it were corrupted it would
be easy to fix by hand.

This hazard has been there all along, so back-patch to all supported
branches.

Michael Paquier, with some kibitzing by me

Discussion: https://postgr.es/m/f4b8eb91-b934-8a0d-b3cc-68f06e2279d1@enterprisedb.com
doc/src/sgml/ref/pg_resetxlog.sgml
src/bin/pg_resetxlog/pg_resetxlog.c