Fix portability issue in pg_upgrade test script: avoid $PWD.
authorTom Lane
Tue, 7 Jul 2015 16:49:18 +0000 (12:49 -0400)
committerTom Lane
Tue, 7 Jul 2015 16:49:18 +0000 (12:49 -0400)
commit58c58d1a9f4ba5372f683eb823e065ed12469e5e
treeed45c304817c6e374dee3d79a7eaf51b3e3cf300
parent992c6f0d2ca839ba54279fbc1a5d5e01e2e18f58
Fix portability issue in pg_upgrade test script: avoid $PWD.

SUSv2-era shells don't set the PWD variable, though anything more modern
does.  In the buildfarm environment this could lead to test.sh executing
with PWD pointing to $HOME or another high-level directory, so that there
were conflicts between concurrent executions of the test in different
branch subdirectories.  This appears to be the explanation for recent
intermittent failures on buildfarm members binturong and dingo (and might
well have something to do with the buildfarm script's failure to capture
log files from pg_upgrade tests, too).

To fix, just use `pwd` in place of $PWD.  AFAICS test.sh is the only place
in our source tree that depended on $PWD.  Back-patch to all versions
containing this script.

Per buildfarm.  Thanks to Oskari Saarenmaa for diagnosing the problem.
contrib/pg_upgrade/test.sh