contrib/isn: Make weak mode a GUC setting, and fix related functions.
authorTom Lane
Sun, 16 Mar 2025 17:45:48 +0000 (13:45 -0400)
committerTom Lane
Sun, 16 Mar 2025 17:45:48 +0000 (13:45 -0400)
commit44890442398cf3a65230d53167e61905d2b0d348
tree1cb9b611315da7ac77b46aef74addc5918cb22d7
parent682c5be25c28192c56e9d5e2a9ca14673a2fcf4b
contrib/isn: Make weak mode a GUC setting, and fix related functions.

isn's weak mode used to be a simple static variable, settable only
via the isn_weak(boolean) function.  This wasn't optimal, as this
means it doesn't respect transactions nor respond to RESET ALL.

This patch makes isn.weak a GUC parameter instead, so that
it acts like any other user-settable parameter.

The isn_weak() functions are retained for backwards compatibility.
But we must fix their volatility markings: they were marked IMMUTABLE
which is surely incorrect, and PARALLEL RESTRICTED which isn't right
for GUC-related functions either.  Mark isn_weak(boolean) as
VOLATILE and PARALLEL UNSAFE, matching set_config().  Mark isn_weak()
as STABLE and PARALLEL SAFE, matching current_setting().

Reported-by: Viktor Holmberg
Diagnosed-by: Daniel Gustafsson
Author: Viktor Holmberg 
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/790bc1f9-74dc-4b50-94d2-8147315b1556@Spark
contrib/isn/Makefile
contrib/isn/expected/isn.out
contrib/isn/isn--1.2--1.3.sql [new file with mode: 0644]
contrib/isn/isn.c
contrib/isn/isn.control
contrib/isn/isn.h
contrib/isn/meson.build
contrib/isn/sql/isn.sql
doc/src/sgml/isn.sgml