Fix past pd_upper write in ginRedoRecompress()
authorAlexander Korotkov
Sun, 9 Sep 2018 18:19:29 +0000 (21:19 +0300)
committerAlexander Korotkov
Sun, 9 Sep 2018 18:45:55 +0000 (21:45 +0300)
commit35ea98f79af299fd946d160eabf0a79e033d8115
tree17be28838a2f03fe5bc534bf81c73f65274284c3
parentd2003339c3969d93750104fc41b5ab27393a952b
Fix past pd_upper write in ginRedoRecompress()

ginRedoRecompress() replays actions over compressed segments of posting list
in-place.  However, it might lead to write past pg_upper, because intermediate
state during playing the changes can take more space than both original state
and final state.  This commit fixes that by refuse from in-place modification.
Instead page tail is copied once modification is started, and then it's used
as the source of original segments.  Backpatch to 9.4 where posting list
compression was introduced.

Reported-by: Sivasubramanian Ramasubramanian
Discussion: https://postgr.es/m/1536091151804.6588%40amazon.com
Author: Alexander Korotkov based on patch from and ideas by Sivasubramanian Ramasubramanian
Review: Sivasubramanian Ramasubramanian
Backpatch-through: 9.4
src/backend/access/gin/ginxlog.c