Relax overly strict assertion
authorAlvaro Herrera
Tue, 12 Feb 2019 21:42:37 +0000 (18:42 -0300)
committerAlvaro Herrera
Tue, 12 Feb 2019 21:42:37 +0000 (18:42 -0300)
commit350cdcd5e6dd505454435af8d7640a4b5042fcfd
tree920ef8eb3622af4861d36c5a42cb348a339aadb3
parent42baa60f6bc70cfffcba6a89a4b7a8b0a929b54d
Relax overly strict assertion

Ever since its birth, ReorderBufferBuildTupleCidHash() has contained an
assertion that a catalog tuple cannot change Cmax after acquiring one.  But
that's wrong: if a subtransaction executes DDL that affects that catalog
tuple, and later aborts and another DDL affects the same tuple, it will
change Cmax.  Relax the assertion to merely verify that the Cmax remains
valid and monotonically increasing, instead.

Add a test that tickles the relevant code.

Diagnosed by, and initial patch submitted by: Arseny Sher
Co-authored-by: Arseny Sher
Discussion: https://postgr.es/m/874l9p8hyw.fsf@ars-thinkpad
contrib/test_decoding/expected/ddl.out
contrib/test_decoding/sql/ddl.sql
src/backend/replication/logical/reorderbuffer.c