Fix off-by-one error in txid_status().
authorThomas Munro
Wed, 27 Mar 2019 08:16:50 +0000 (21:16 +1300)
committerThomas Munro
Wed, 27 Mar 2019 08:30:49 +0000 (21:30 +1300)
commit26d4fda37ea10d146e9d35fca70f817a0bfe300c
tree06b73d159c858f2dbdf701fd1865fcdc05f550eb
parentfb0b5b0b84a0a07d722f67fee1da8d2541f84172
Fix off-by-one error in txid_status().

The transaction ID returned by GetNextXidAndEpoch() is in the future,
so we can't attempt to access its status or we might try to read a
CLOG page that doesn't exist.  The > vs >= confusion probably stemmed
from the choice of a variable name containing the word "last" instead
of "next", so fix that too.

Back-patch to 10 where the function arrived.

Author: Thomas Munro
Discussion: https://postgr.es/m/CA%2BhUKG%2Buua_BV5cyfsioKVN2d61Lukg28ECsWTXKvh%3DBtN2DPA%40mail.gmail.com
src/backend/utils/adt/txid.c