Fix assert in logicalmsg_desc
authorTomas Vondra
Tue, 16 Aug 2022 21:52:10 +0000 (23:52 +0200)
committerTomas Vondra
Tue, 16 Aug 2022 22:17:37 +0000 (00:17 +0200)
commit239c3ee41be3b7c621c446344d09e3affeb8cd59
tree3ec0e0a94282add8b5e8443b3922d15577f1da03
parent1d968b87047708eae1d0eef27860668ec318a3ee
Fix assert in logicalmsg_desc

The assert, introduced by 9f1cf97bb5, is intended to check if the prefix
is terminated by a \0 byte, but it has two flaws. Firstly, prefix_size
includes the \0 byte, so prefix[prefix_size] points to the byte after
the null byte. Secondly, the check ensures the byte is not equal \0,
while it should be checking the opposite.

Backpatch-through: 14
Discussion: https://postgr.es/m/b99b6101-2f14-3796-3dfa-4a6cd7d4326d@enterprisedb.com
src/backend/access/rmgrdesc/logicalmsgdesc.c