Drop slot's LWLock before returning from SaveSlotToPath()
authorPeter Eisentraut
Thu, 26 Mar 2020 10:51:39 +0000 (11:51 +0100)
committerPeter Eisentraut
Thu, 26 Mar 2020 12:31:07 +0000 (13:31 +0100)
commit223e9c77dcaf8788fdca2fab3a3b65b797a54615
tree135447dad22a46d956ddb94ce3ac21ef6bea1c60
parenta86715451653c730d637847b403b0420923956f7
Drop slot's LWLock before returning from SaveSlotToPath()

When SaveSlotToPath() is called with elevel=LOG, the early exits didn't
release the slot's io_in_progress_lock.

This could result in a walsender being stuck on the lock forever.  A
possible way to get into this situation is if the offending code paths
are triggered in a low disk space situation.

Author: Pavan Deolasee 
Reported-by: Craig Ringer
Discussion: https://www.postgresql.org/message-id/flat/56a138c5-de61-f553-7e8f-6789296de785%402ndquadrant.com
src/backend/replication/slot.c