Don't shut down Gather[Merge] early under Limit.
authorAmit Kapila
Mon, 18 Nov 2019 08:47:41 +0000 (14:17 +0530)
committerAmit Kapila
Tue, 26 Nov 2019 03:25:06 +0000 (08:55 +0530)
commit1cc3a90c7551cf1f33611152eba2bca56e0b721e
tree11125352380affaa31507d4a7ed8a513b3a78d39
parenta24a4167aa3889d26c425d38a8c67cc39df35fbd
Don't shut down Gather[Merge] early under Limit.

Revert part of commit 19df1702f5.

Early shutdown was added by that commit so that we could collect
statistics from workers, but unfortunately, it interacted badly with
rescans.  The problem is that we ended up destroying the parallel context
which is required for rescans.  This leads to rescans of a Limit node over
a Gather node to produce unpredictable results as it tries to access
destroyed parallel context.  By reverting the early shutdown code, we
might lose statistics in some cases of Limit over Gather [Merge], but that
will require further study to fix.

Reported-by: Jerry Sievers
Diagnosed-by: Thomas Munro
Author: Amit Kapila, testcase by Vignesh C
Backpatch-through: 9.6
Discussion: https://postgr.es/m/[email protected]
src/backend/executor/nodeLimit.c
src/test/regress/expected/select_parallel.out
src/test/regress/sql/select_parallel.sql