Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline.
authorTom Lane
Mon, 21 Nov 2022 22:07:07 +0000 (17:07 -0500)
committerTom Lane
Mon, 21 Nov 2022 22:07:07 +0000 (17:07 -0500)
commit1b9c04b1389b0e8ee7f493477c22c25f65a2f89a
tree8adcd4aef5d404d8dc99d522e20d9ced69406cfc
parent47a22dc2cb89aca2e54c9cf9fe2da4a5e8ba4cb4
Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline.

I just spent an annoying amount of time reverse-engineering the
100%-undocumented API between ts_headline and the text search
parser's prsheadline function.  Add some commentary about that
while it's fresh in mind.  Also remove some unused macros in
wparser_def.c.

While at it, I noticed that when commit 78e73e875 added a
CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed
doing so in the parallel function TS_phrase_execute, which
surely needs one just as much.

Back-patch because of the missing CHECK_FOR_INTERRUPTS.
Might as well back-patch the rest of this too.
src/backend/tsearch/ts_parse.c
src/backend/tsearch/wparser_def.c
src/backend/utils/adt/tsvector_op.c
src/include/tsearch/ts_public.h