Fix asymmetry in setting EquivalenceClass.ec_sortref
authorAlexander Korotkov
Thu, 6 Jun 2024 10:41:34 +0000 (13:41 +0300)
committerAlexander Korotkov
Thu, 6 Jun 2024 10:41:34 +0000 (13:41 +0300)
commit199012a3d844c6283e0ab4b1139440840a91433d
tree8293d986f3ae2c0259e30bcbfc328d2d697660ae
parentf654f000ddfd2c8724d0d7085087424f6ab51515
Fix asymmetry in setting EquivalenceClass.ec_sortref

0452b461bc made get_eclass_for_sort_expr() always set
EquivalenceClass.ec_sortref if it's not done yet.  This leads to an asymmetric
situation when whoever first looks for the EquivalenceClass sets the
ec_sortref.  It is also counterintuitive that get_eclass_for_sort_expr()
performs modification of data structures.

This commit makes make_pathkeys_for_sortclauses_extended() responsible for
setting EquivalenceClass.ec_sortref.  Now we set the
EquivalenceClass.ec_sortref's needed to explore alternative GROUP BY ordering
specifically during building pathkeys by the list of grouping clauses.

Discussion: https://postgr.es/m/17037754-f187-4138-8285-0e2bfebd0dea%40postgrespro.ru
Reported-by: Tom Lane
Author: Andrei Lepikhov
Reviewed-by: Alexander Korotkov, Pavel Borisov
src/backend/optimizer/path/equivclass.c
src/backend/optimizer/path/pathkeys.c
src/backend/optimizer/plan/planner.c
src/include/optimizer/paths.h
src/test/regress/expected/aggregates.out
src/test/regress/sql/aggregates.sql